| 39660 06.01.2009 21:33:54, by oliver@apple.com:
<https://bugs.webkit.org/show_bug.cgi?id=23085> [jsfunfuzz] Over released ScopeChainNode
<rdar://problem/6474110>
Reviewed by Cameron Zwarich
So this delightful bug was caused by our unwind code using a ScopeChain to perform
the unwind. The ScopeChain would ref the initial top of the scope chain, then deref
the resultant top of scope chain, which is incorrect.
This patch removes the dependency on ScopeChain for the unwind, and i've filed
<https://bugs.webkit.org/show_bug.cgi?id=23144> to look into the unintuitive
ScopeChain behaviour. |
| 39659 06.01.2009 21:16:08, by eric@webkit.org:
Build fix only, no review.
Bring the Chromium-WebCore build back closer to building
by adding files from recent commits.
* WebCore.scons: |
| 39658 06.01.2009 20:49:06, by aroben@apple.com:
Hopeful Windows crash-on-launch fix
* wtf/Platform.h: Force a world rebuild by touching this file. |
| 39657 06.01.2009 19:19:55, by zecke@webkit.org:
Build fix by building ByteArray.cpp as well |
| 39656 06.01.2009 19:12:48, by ap@webkit.org:
Reviewed by Darin Adler.
<rdar://problem/6474973> REGRESSION: PLT ~2% slower due to 39465 (consolidate thread data)
I could not reproduce the slowdown on my PowerPC test machine, but the change should bring
performance back.
* platform/ThreadGlobalData.cpp: (WebCore::threadGlobalData): Don't use AtomicallyInitializedStatic.
Prior to r39465, it was only used for cached converters, which was necessary because the
first access to ICU or TEC one could happen on a secondary thread, but now they are all
initialized from ThreadGlobalData constructor. |
| 39655 06.01.2009 18:08:22, by treat@webkit.org:
Update the documentation to reflect when these API changes will land in
upstream Qt |
| 39654 06.01.2009 17:14:49, by dsmith@webkit.org:
2009-01-06 David Smith <catfish.man@gmail.com>
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=23129
Devirtualize Node::childNodes(). |
| 39653 06.01.2009 17:13:31, by zecke@webkit.org:
Speculative build fix for Gtk+ |
| 39652 06.01.2009 15:54:23, by ddkilzer@apple.com:
BUILD FIX (r39641): Try to fix WebIconDatabase build errors #4
* WebIconDatabase.cpp:
(WebIconDatabase::isEnabled): Added 'WebIconDatabase::' to method
signature. (Another copy-paste error.)
(WebIconDatabase::setEnabled): Ditto.
* WebIconDatabase.h:
(WebIconDatabase::startUpIconDatabase): Make private again.
(WebIconDatabase::shutDownIconDatabase): Ditto. |
| 39651 06.01.2009 15:49:52, by hausmann@webkit.org:
2009-01-06 Simon Hausmann <simon.hausmann@nokia.com>
Unreviewed build fix.
Fix the Qt build with Qt 4.4.x, the HTTP-only cookie support was
added in Qt 4.5. |
| 39650 06.01.2009 15:38:55, by ddkilzer@apple.com:
2009-01-06 Zalan Bujtas <zbujtas@gmail.com>
Reviewed by David Kilzer.
https://bugs.webkit.org/show_bug.cgi?id=23133
Fix SVG disabled build. Move 'pointer-events' from SVGCSSPropertyNames.in to
CSSPropertyNames.in and move PointerEvents functions out of #if ENABLE(SVG)
NOTE: Property name fixes landed as part of r39648.
* css/CSSPrimitiveValueMappings.h:
(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
(WebCore::CSSPrimitiveValue::operator EPointerEvents):
* css/CSSPropertyNames.in:
* css/SVGCSSPropertyNames.in: |
| 39649 06.01.2009 15:29:36, by ddkilzer@apple.com:
BUILD FIX (r39641): Try to fix build errors #3
Try to fix the following (more specific) build errors:
WebIconDatabase.cpp
..\WebIconDatabase.cpp(255) : error C2248: 'WebIconDatabase::shutDownIconDatabase' : cannot access private member declared in class 'WebIconDatabase'
...\webkit\win\WebIconDatabase.h(61) : see declaration of 'WebIconDatabase::shutDownIconDatabase'
...\webkit\win\WebIconDatabase.h(51) : see declaration of 'WebIconDatabase'
..\WebIconDatabase.cpp(255) : error C2352: 'WebIconDatabase::shutDownIconDatabase' : illegal call of non-static member function
...\webkit\win\WebIconDatabase.h(61) : see declaration of 'WebIconDatabase::shutDownIconDatabase'
..\WebIconDatabase.cpp(258) : error C2248: 'WebIconDatabase::startUpIconDatabase' : cannot access private member declared in class 'WebIconDatabase'
...\webkit\win\WebIconDatabase.h(60) : see declaration of 'WebIconDatabase::startUpIconDatabase'
...\webkit\win\WebIconDatabase.h(51) : see declaration of 'WebIconDatabase'
..\WebIconDatabase.cpp(258) : error C2352: 'WebIconDatabase::startUpIconDatabase' : illegal call of non-static member function
...\webkit\win\WebIconDatabase.h(60) : see declaration of 'WebIconDatabase::startUpIconDatabase'
* WebIconDatabase.cpp:
(setEnabled): Get instance of shared WebIconDatabase, then call
startUp/shutDown methods on it.
* WebIconDatabase.h:
(WebIconDatabase::startUpIconDatabase): Make protected again.
(WebIconDatabase::shutDownIconDatabase): Ditto. |
| 39648 06.01.2009 15:06:25, by ddkilzer@apple.com:
BUILD FIX (r39634): Fix build for non-SVG builds (Wx)
* css/CSSPropertyNames.in: Added 'pointer-events'.
* css/SVGCSSPropertyNames.in: Commented out pointer-events
since it's now a plain CSS property. |
| 39647 06.01.2009 14:59:51, by ddkilzer@apple.com:
BUILD FIX (r39641): Try to fix build errors again
Try to fix the following build errors:
WebIconDatabase.cpp
..\WebIconDatabase.cpp(255) : error C3861: 'shutDownIconDatabase': identifier not found
..\WebIconDatabase.cpp(258) : error C3861: 'startUpIconDatabase': identifier not found
* WebIconDatabase.cpp:
(setEnabled): Add class prefix to startUpIconDatabase() and
shutDownIconDatabase().
* WebIconDatabase.h:
(WebIconDatabase::startUpIconDatabase): Make private again.
(WebIconDatabase::shutDownIconDatabase): Ditto. |
| 39646 06.01.2009 14:45:50, by ddkilzer@apple.com:
BUILD FIX (r39641): Try to fix build error
Try to fix the following build errors:
WebIconDatabase.cpp
..\WebIconDatabase.cpp(255) : error C3861: 'shutDownIconDatabase': identifier not found
..\WebIconDatabase.cpp(258) : error C3861: 'startUpIconDatabase': identifier not found
* WebIconDatabase.h:
(WebIconDatabase::startUpIconDatabase): Make protected.
(WebIconDatabase::shutDownIconDatabase): Ditto. |
| 39645 06.01.2009 14:07:03, by ddkilzer@apple.com:
BUILD FIX (r39641): Fix more silly errors
Fixes the following compilation errors:
WebIconDatabase.cpp
..\WebIconDatabase.cpp(85) : error C2065: 'standardPrefs' : undeclared identifier
..\WebIconDatabase.cpp(85) : error C2227: left of '->iconDatabaseLocation' must point to class/struct/union/generic type
type is ''unknown-type''
..\WebIconDatabase.cpp(241) : error C2575: 'isEnabled' : only member functions and bases can be virtual
..\WebIconDatabase.cpp(248) : error C2575: 'setEnabled' : only member functions and bases can be virtual
..\WebIconDatabase.cpp(253) : error C3861: 'shutDownIconDatabase': identifier not found
..\WebIconDatabase.cpp(256) : error C3861: 'startUpIconDatabase': identifier not found
* WebIconDatabase.cpp:
(WebIconDatabase::startUpIconDatabase): Redeclare standardPrefs
since this was in init() but not in this method after it was
extracted from init().
(isEnabled): Don't use "virtual" in method implementation
(silly copy-paste error).
(setEnabled): Ditto. |
| 39644 06.01.2009 13:40:07, by ddkilzer@apple.com:
BUILD FIX (r39641): Remove STDMETHODCALLTYPE from method declarations in IWebIconDatabase.idl
* Interfaces/IWebIconDatabase.idl: Removed "STDMETHODCALLTYPE"
from silly copy-paste error in two method declarations. |
| 39643 06.01.2009 10:35:27, by hausmann@webkit.org:
2009-01-06 Simon Hausmann <simon.hausmann@nokia.com>
Reviewed by Lars Knoll.
Added support for HTTP-only cookies to the Qt build. |
| 39642 06.01.2009 08:39:05, by dsmith@webkit.org:
2009-01-05 David Smith <catfish.man@gmail.com>
Reviewed by Oliver Hunt.
https://bugs.webkit.org/show_bug.cgi?id=23084
Avoid redundant AtomicString conversions
* dom/Node.cpp: Create an AtomicString early to avoid converting twice
(WebCore::Node::getElementsByTagNameNS):
* dom/QualifiedName.h: Use the appropriate AtomicString constructor instead of converting from a String |
| 39641 06.01.2009 07:13:15, by ddkilzer@apple.com:
WebKit/mac:
2009-01-05 David Kilzer <ddkilzer@apple.com>
Add SPI to enable, disable and check state of WebIconDatabase
Reviewed by Darin Adler & Timothy Hatcher.
Add -[WebIconDatabase isEnabled] and -[WebIconDatabase setEnabled:]
SPI to make it possible to enable, disable and check the state of
the icon database.
* Misc/WebIconDatabase.mm:
(-[WebIconDatabase init]): Extracted code into -_startUpIconDatabase.
(-[WebIconDatabase iconForURL:withSize:cache:]): Switched to use
-isEnabled instead of -_isEnabled.
(-[WebIconDatabase iconURLForURL:]): Ditto.
(-[WebIconDatabase retainIconForURL:]): Ditto.
(-[WebIconDatabase releaseIconForURL:]): Ditto.
(-[WebIconDatabase isEnabled]): Renamed from -_isEnabled in
WebInternal category.
(-[WebIconDatabase setEnabled:]): Added. Takes care of changing
the enabled/disabled state of the icon database.
(-[WebIconDatabase removeAllIcons]): Switched to use -isEnabled
instead of -_isEnabled.
(-[WebIconDatabase _startUpIconDatabase]): Added. Extrated from
-init.
(-[WebIconDatabase _shutDownIconDatabase]): Added. Remove
observers when the icon database is disabled.
* Misc/WebIconDatabaseInternal.h: Added declarations for
-_startUpIconDatabase and -_shutDownIconDatabase.
* Misc/WebIconDatabasePrivate.h: Added declarations for
-isEnabled and -setEnabled:.
WebKit/win:
2009-01-05 David Kilzer <ddkilzer@apple.com>
Add API to enable, disable and check state of WebIconDatabase
Reviewed by Darin Adler & Timothy Hatcher.
Add WebIconDatabase::isEnabled() and WebIconDatabase::setEnabled()
API to make it possible to enable, disable and check the state of
the icon database.
* Interfaces/IWebIconDatabase.idl: Declared isEnabled() and
setEnabled() methods.
* WebIconDatabase.cpp:
(WebIconDatabase::init): Extracted code into startUpIconDatabase().
(WebIconDatabase::startUpIconDatabase): Added. Extracted from
init().
(WebIconDatabase::shutDownIconDatabase): Added. Method is empty
since there is nothing to do yet on Windows.
(isEnabled): Added.
(setEnabled): Added.
* WebIconDatabase.h: Added method declarations. |
|
|