| 64436 01.08.2010 07:53:32, by
mitz@apple.com
Fix typo in attempted build fix.
* platform/graphics/WOFFFileFormat.cpp: |
| 64435 01.08.2010 07:47:37, by
mitz@apple.com
Try to fix the Windows build when zlib is not available.
* platform/graphics/WOFFFileFormat.cpp: |
| 64434 01.08.2010 07:04:57, by
mitz@apple.com
<rdar://problem/8234766> Add WOFF support for @font-face
https://bugs.webkit.org/show_bug.cgi?id=31302
Reviewed by Darin Adler.
WebCore:
* WebCore.vcproj/WebCore.vcproj: Added WOFFFileFormat.{cpp,h}.
* WebCore.vcproj/WebCoreCommon.vsprops: Added $(WebKitLibraries)\include\zlib to the header search path.
* WebCore.xcodeproj/project.pbxproj: Added WOFFFileFormat.{cpp,h} and linking against libz.
* css/CSSFontFaceSrcValue.cpp:
(WebCore::CSSFontFaceSrcValue::isSupportedFormat): Replaced hard-coded list of supported formats with
call to FontCustomPlatformData::supportsFormat().
* platform/graphics/WOFFFileFormat.cpp: Added.
(WebCore::isWOFF): Checks if the buffer has the WOFF signature.
(WebCore::convertWOFFToSfnt): Extracts the sfnt payload of a WOFF package.
* platform/graphics/WOFFFileFormat.h: Added.
* platform/graphics/cairo/FontCustomPlatformData.cpp:
(WebCore::FontCustomPlatformData::supportsFormat): Added. Returns true for truetype and opentype.
* platform/graphics/cairo/FontCustomPlatformData.h:
* platform/graphics/chromium/FontCustomPlatformData.cpp:
(WebCore::FontCustomPlatformData::supportsFormat): Added. Returns true for truetype and opentype,
and also for woff if the OpenType sanitizer is enabled.
* platform/graphics/chromium/FontCustomPlatformData.h:
* platform/graphics/gtk/FontCustomPlatformDataPango.cpp:
(WebCore::FontCustomPlatformData::supportsFormat): Added. Returns false.
* platform/graphics/haiku/FontCustomPlatformData.cpp:
(WebCore::FontCustomPlatformData::supportsFormat): Ditto.
* platform/graphics/haiku/FontCustomPlatformData.h:
* platform/graphics/mac/FontCustomPlatformData.cpp:
(WebCore::freeSfntData):
(WebCore::createFontCustomPlatformData): If the OpenType font sanitizer is not enabled, use convertWOFFToSfnt().
(WebCore::FontCustomPlatformData::supportsFormat): Added. Returns true for truetype, opentype and woff.
* platform/graphics/mac/FontCustomPlatformData.h:
* platform/graphics/qt/FontCustomPlatformData.h:
* platform/graphics/qt/FontCustomPlatformDataQt.cpp:
(WebCore::FontCustomPlatformData::supportsFormat): Added. Returns true for truetype and opentype.
* platform/graphics/win/FontCustomPlatformData.cpp:
(WebCore::createFontCustomPlatformData): If the OpenType font sanitizer is not enabled, use convertWOFFToSfnt().
(WebCore::FontCustomPlatformData::supportsFormat): Added. Returns true for truetype, opentype and woff.
* platform/graphics/win/FontCustomPlatformData.h:
* platform/graphics/win/FontCustomPlatformDataCairo.cpp:
(WebCore::FontCustomPlatformData::supportsFormat): Added. Returns true for truetype and opentype.
* platform/graphics/win/FontCustomPlatformDataCairo.h:
* platform/graphics/wince/FontCustomPlatformData.cpp:
(WebCore::FontCustomPlatformData::supportsFormat): Ditto.
* platform/graphics/wince/FontCustomPlatformData.h:
LayoutTests:
* platform/mac/Skipped: Enabled fast/css/font-face-woff.html.
* platform/mac/fast/css/font-face-woff-expected.checksum: Added.
* platform/mac/fast/css/font-face-woff-expected.png: Added.
* platform/mac/fast/css/font-face-woff-expected.txt: Added. |
| 64433 01.08.2010 06:19:19, by
weinig@apple.com
Update skipped list to get us to ~100 failures for Mac WebKit2.
Rubber-stamped by Dan Bernstein.
* platform/mac-wk2/Skipped: |
| 64432 01.08.2010 03:10:27, by
rniwa@webkit.org
2010-07-31 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Ojan Vafai.
SplitElementCommand shouldn't be duplicating id attribute
https://bugs.webkit.org/show_bug.cgi?id=27156
Modified SplitElementCommand to delete the id attribute from the second element when splitting an element.
Since this causes WebKit not to merge split elements, added shouldSplitElement to ApplyStyleCommand which
determines the necessity of splitting the element.
To share code between shouldSplitElement and removeInlineStyleFromElement (extracted from applyInlineStyle)
dontRemove was added as the 3rd argument to removeHTMLFontStyle, removeHTMLBidiEmbeddingStyle, and removeCSSStyle.
Test: editing/style/split-element-id-duplication.html
* editing/ApplyStyleCommand.cpp:
(WebCore::ApplyStyleCommand::applyBlockStyle): Added 3rd argument for removeCSSStyle.
(WebCore::ApplyStyleCommand::applyInlineStyle): Calls shouldSplitElement.
(WebCore::ApplyStyleCommand::removeInlineStyleFromElement): Extracted from removeInlineStyle.
(WebCore::ApplyStyleCommand::shouldRemoveInlineStyleFromElement): Inline helper for removeInlineStyleFromElement.
(WebCore::ApplyStyleCommand::removeHTMLFontStyle): Added dontRemove.
(WebCore::ApplyStyleCommand::removeHTMLBidiEmbeddingStyle): Added dontRemove.
(WebCore::ApplyStyleCommand::removeCSSStyle): Added dontRemove.
(WebCore::ApplyStyleCommand::removeInlineStyle): Calls removeInlineStyleFromElement.
(WebCore::ApplyStyleCommand::splitTextElementAtStart): Removed the call to splitTextAtStart.
Branching is now done in applyInlineStyle.
(WebCore::ApplyStyleCommand::splitTextElementAtEnd): Ditto for splitTextAtEnd.
(WebCore::ApplyStyleCommand::shouldSplitElement): Added.
* editing/ApplyStyleCommand.h:
* editing/SplitElementCommand.cpp:
(WebCore::SplitElementCommand::executeApply): Deletes the id attribute from the second element.
(WebCore::SplitElementCommand::doUnapply): Recovers the id attribute of the second element.
2010-07-31 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Ojan Vafai.
SplitElementCommand shouldn't be duplicating id attribute
https://bugs.webkit.org/show_bug.cgi?id=27156
Added a test to ensure splitting element doesn't produce multiple nodes with the same id.
* editing/execCommand/indent-nested-blockquotes-expected.txt: Removed the duplication of nodes with the same id.
* editing/execCommand/indent-pre-expected.txt: Ditto.
* editing/execCommand/indent-second-paragraph-in-blockquote-expected.txt: Ditto.
* editing/execCommand/outdent-regular-blockquote-expected.txt:
* editing/style/split-element-id-duplication-expected.txt: Added.
* editing/style/split-element-id-duplication.html: Added.
* editing/undo/redo-style-expected.txt: Editing delegates changed. |
| 64431 01.08.2010 02:59:10, by
atwilson@chromium.org
Unreviewed text expectations change for Chromium.
Patch by Satish Sampath <satish@chromium.org> on 2010-07-31
Disable speech input layout tests while they get updated.
https://bugs.webkit.org/show_bug.cgi?id=43310
* platform/chromium/test_expectations.txt: Disabled speech input tests. |
| 64430 01.08.2010 02:42:40, by
weinig@apple.com
Crash due to calling StringImpl::createCFString() from non-main thread in plug-in code
https://bugs.webkit.org/show_bug.cgi?id=43306
<rdar://problem/8259687>
Reviewed by Darin Adler.
* UIProcess/Plugins/PluginInfoStore.cpp:
(WebKit::PluginInfoStore::getMIMETypeForExtension):
(WebKit::PluginInfoStore::findPlugin):
* UIProcess/Plugins/PluginInfoStore.h:
* UIProcess/Plugins/mac/PluginInfoStoreMac.mm:
(WebKit::safeCreateCFString):
(WebKit::PluginInfoStore::getMIMETypeForExtension):
Bypass MIMETypeRegistry in the UIProcess until we can safely convert Strings
to CFStringRefs. |
| 64429 01.08.2010 01:43:23, by
luiz@webkit.org
2010-07-31 Luiz Agostini <luiz.agostini@openbossa.org>
Build fix: Windows.
* platform/win/PopupMenuWin.h:
2010-07-31 Luiz Agostini <luiz.agostini@openbossa.org>
Build fix: Windows.
* WebView.cpp:
(WebView::mouseWheel): |
| 64428 01.08.2010 01:41:49, by
ddkilzer@apple.com
<http://webkit.org/b/43307> Make sure all private headers are copied to PrivateHeaders directory
Reviewed by Dan Bernstein.
This also fixes compilation of DumpRenderTree after changes for
Bug 40627.
* WebKit.xcodeproj/project.pbxproj: Set the PRIVATE attribute on
the following headers:
- WebFormDelegatePrivate.h
- WebKitStatisticsPrivate.h
- WebSecurityOriginPrivate.h |
| 64427 01.08.2010 01:12:50, by
luiz@webkit.org
2010-07-31 Luiz Agostini <luiz.agostini@openbossa.org>
Windows build fix.
* platform/win/PopupMenuWin.cpp:
(WebCore::PopupMenuWin::PopupMenuWndProc): |
| 64426 01.08.2010 00:37:35, by
weinig@apple.com
Patch for https://bugs.webkit.org/show_bug.cgi?id=43305
Add back WKBundleFrameCopyInnerText to fix ~50 test failures
due to SVGElements not having the innerText function.
Reviewed by Dan Bernstein.
WebKit2:
* WebProcess/InjectedBundle/API/c/WKBundleFrame.cpp:
(WKBundleFrameCopyInnerText):
* WebProcess/InjectedBundle/API/c/WKBundleFramePrivate.h:
* WebProcess/WebPage/WebFrame.cpp:
(WebKit::WebFrame::innerText):
* WebProcess/WebPage/WebFrame.h:
WebKitTools:
* WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
(WTR::dumpFrameText): |
| 64425 01.08.2010 00:25:11, by
luiz@webkit.org
2010-07-27 Luiz Agostini <luiz.agostini@openbossa.org>
Reviewed by Darin Fisher.
PopupMenu refactoring in preparation to WebKit2
https://bugs.webkit.org/show_bug.cgi?id=42592
Classes PopupMenu and SearchPopupMenu have been made pure virtual.
* platform/PopupMenu.h:
(WebCore::PopupMenu::~PopupMenu):
* platform/SearchPopupMenu.h:
(WebCore::SearchPopupMenu::~SearchPopupMenu):
Classes RenderMenuList and RenderTexyControlSingleLine have been changed to use
the new pure virtual PopupMenu and SearchPopupMenu.
* rendering/RenderMenuList.cpp:
(WebCore::RenderMenuList::adjustInnerStyle):
(WebCore::RenderMenuList::showPopup):
* rendering/RenderMenuList.h:
* rendering/RenderTextControlSingleLine.cpp:
(WebCore::RenderTextControlSingleLine::~RenderTextControlSingleLine):
(WebCore::RenderTextControlSingleLine::addSearchResult):
(WebCore::RenderTextControlSingleLine::showPopup):
(WebCore::RenderTextControlSingleLine::hidePopup):
(WebCore::RenderTextControlSingleLine::updateFromElement):
(WebCore::RenderTextControlSingleLine::valueChanged):
* rendering/RenderTextControlSingleLine.h:
Chrome and ChromeClient were made responsible for providing instances of classes
PopupMenu and SearchPopupMenu to its users.
* loader/EmptyClients.h:
(WebCore::EmptyPopupMenu::show):
(WebCore::EmptyPopupMenu::hide):
(WebCore::EmptyPopupMenu::updateFromElement):
(WebCore::EmptyPopupMenu::disconnectClient):
(WebCore::EmptySearchPopupMenu::popupMenu):
(WebCore::EmptySearchPopupMenu::saveRecentSearches):
(WebCore::EmptySearchPopupMenu::loadRecentSearches):
(WebCore::EmptySearchPopupMenu::enabled):
(WebCore::EmptyChromeClient::selectItemWritingDirectionIsNatural):
(WebCore::EmptyChromeClient::createPopupMenu):
(WebCore::EmptyChromeClient::createSearchPopupMenu):
* page/Chrome.cpp:
(WebCore::Chrome::selectItemWritingDirectionIsNatural):
(WebCore::Chrome::createPopupMenu):
(WebCore::Chrome::createSearchPopupMenu):
* page/Chrome.h:
* page/ChromeClient.h:
Original contents of files PopupMenu.h and SearchPopupMenu.h have been splited
in several files, two for each platform (PopupMenuXXX.h and SearchPopupMenuXXX.h).
Each of new the files contain the concrete classes that inherit form PopupMenu or
SearchPopupMenu and are specific for the corresponding platform.
brew:
* platform/brew/PopupMenuBrew.cpp:
(WebCore::PopupMenuBrew::PopupMenuBrew):
(WebCore::PopupMenuBrew::~PopupMenuBrew):
(WebCore::PopupMenuBrew::disconnectClient):
(WebCore::PopupMenuBrew::show):
(WebCore::PopupMenuBrew::hide):
(WebCore::PopupMenuBrew::updateFromElement):
* platform/brew/PopupMenuBrew.h: Added.
(WebCore::PopupMenuBrew::client):
* platform/brew/SearchPopupMenuBrew.cpp:
(WebCore::SearchPopupMenuBrew::saveRecentSearches):
(WebCore::SearchPopupMenuBrew::loadRecentSearches):
(WebCore::SearchPopupMenuBrew::SearchPopupMenuBrew):
(WebCore::SearchPopupMenuBrew::enabled):
(WebCore::SearchPopupMenuBrew::popupMenu):
* platform/brew/SearchPopupMenuBrew.h: Added.
chromium:
* WebCore.gypi:
* platform/chromium/PopupMenuChromium.cpp:
(WebCore::PopupMenuChromium::PopupMenuChromium):
(WebCore::PopupMenuChromium::~PopupMenuChromium):
(WebCore::PopupMenuChromium::show):
(WebCore::PopupMenuChromium::hide):
(WebCore::PopupMenuChromium::updateFromElement):
(WebCore::PopupMenuChromium::disconnectClient):
* platform/chromium/PopupMenuChromium.h:
(WebCore::PopupMenuChromium::client):
* platform/chromium/SearchPopupMenuChromium.cpp:
(WebCore::SearchPopupMenuChromium::SearchPopupMenuChromium):
(WebCore::SearchPopupMenuChromium::popupMenu):
(WebCore::SearchPopupMenuChromium::enabled):
(WebCore::SearchPopupMenuChromium::saveRecentSearches):
(WebCore::SearchPopupMenuChromium::loadRecentSearches):
* platform/chromium/SearchPopupMenuChromium.h: Added.
efl:
* platform/efl/PopupMenuEfl.cpp:
(WebCore::PopupMenuEfl::PopupMenuEfl):
(WebCore::PopupMenuEfl::~PopupMenuEfl):
(WebCore::PopupMenuEfl::show):
(WebCore::PopupMenuEfl::hide):
(WebCore::PopupMenuEfl::updateFromElement):
(WebCore::PopupMenuEfl::disconnectClient):
* platform/efl/PopupMenuEfl.h: Added.
(WebCore::PopupMenuEfl::client):
* platform/efl/SearchPopupMenuEfl.cpp:
(WebCore::SearchPopupMenuEfl::SearchPopupMenuEfl):
(WebCore::SearchPopupMenuEfl::popupMenu):
(WebCore::SearchPopupMenuEfl::saveRecentSearches):
(WebCore::SearchPopupMenuEfl::loadRecentSearches):
(WebCore::SearchPopupMenuEfl::enabled):
* platform/efl/SearchPopupMenuEfl.h: Added.
gtk:
* GNUmakefile.am:
* platform/gtk/PopupMenuGtk.cpp:
(WebCore::PopupMenuGtk::PopupMenuGtk):
(WebCore::PopupMenuGtk::~PopupMenuGtk):
(WebCore::PopupMenuGtk::show):
(WebCore::PopupMenuGtk::hide):
(WebCore::PopupMenuGtk::updateFromElement):
(WebCore::PopupMenuGtk::disconnectClient):
(WebCore::PopupMenuGtk::menuItemActivated):
(WebCore::PopupMenuGtk::menuUnmapped):
(WebCore::PopupMenuGtk::menuPositionFunction):
(WebCore::PopupMenuGtk::menuRemoveItem):
* platform/gtk/PopupMenuGtk.h: Added.
(WebCore::PopupMenuGtk::client):
* platform/gtk/SearchPopupMenuGtk.cpp:
(WebCore::SearchPopupMenuGtk::SearchPopupMenuGtk):
(WebCore::SearchPopupMenuGtk::popupMenu):
(WebCore::SearchPopupMenuGtk::saveRecentSearches):
(WebCore::SearchPopupMenuGtk::loadRecentSearches):
(WebCore::SearchPopupMenuGtk::enabled):
* platform/gtk/SearchPopupMenuGtk.h: Added.
haiku:
* platform/haiku/PopupMenuHaiku.cpp:
(WebCore::HaikuPopup::HaikuPopup):
(WebCore::HaikuPopup::~HaikuPopup):
(WebCore::PopupMenuHaiku::PopupMenuHaiku):
(WebCore::PopupMenuHaiku::~PopupMenuHaiku):
(WebCore::PopupMenuHaiku::disconnectClient):
(WebCore::PopupMenuHaiku::show):
(WebCore::PopupMenuHaiku::hide):
(WebCore::PopupMenuHaiku::updateFromElement):
* platform/haiku/PopupMenuHaiku.h: Added.
(WebCore::PopupMenuHaiku::disconnectClient):
(WebCore::PopupMenuHaiku::client):
* platform/haiku/SearchPopupMenuHaiku.cpp:
(WebCore::SearchPopupMenuHaiku::SearchPopupMenuHaiku):
(WebCore::SearchPopupMenuHaiku::saveRecentSearches):
(WebCore::SearchPopupMenuHaiku::loadRecentSearches):
(WebCore::SearchPopupMenuHaiku::enabled):
(WebCore::SearchPopupMenuHaiku::popupMenu):
* platform/haiku/SearchPopupMenuHaiku.h: Added.
mac:
* WebCore.exp.in:
* WebCore.xcodeproj/project.pbxproj:
* platform/mac/PopupMenuMac.h: Added.
(WebCore::PopupMenuMac::disconnectClient):
(WebCore::PopupMenuMac::client):
* platform/mac/PopupMenuMac.mm:
(WebCore::PopupMenuMac::PopupMenuMac):
(WebCore::PopupMenuMac::~PopupMenuMac):
(WebCore::PopupMenuMac::clear):
(WebCore::PopupMenuMac::populate):
(WebCore::PopupMenuMac::show):
(WebCore::PopupMenuMac::hide):
(WebCore::PopupMenuMac::updateFromElement):
(WebCore::PopupMenuMac::itemWritingDirectionIsNatural):
* platform/mac/SearchPopupMenuMac.h: Added.
* platform/mac/SearchPopupMenuMac.mm:
(WebCore::SearchPopupMenuMac::SearchPopupMenuMac):
(WebCore::SearchPopupMenuMac::popupMenu):
(WebCore::SearchPopupMenuMac::enabled):
(WebCore::SearchPopupMenuMac::saveRecentSearches):
(WebCore::SearchPopupMenuMac::loadRecentSearches):
qt:
* WebCore.pro:
* platform/qt/PopupMenuQt.cpp:
(WebCore::PopupMenuQt::PopupMenuQt):
(WebCore::PopupMenuQt::~PopupMenuQt):
(WebCore::PopupMenuQt::disconnectClient):
(WebCore::PopupMenuQt::show):
(WebCore::PopupMenuQt::hide):
(WebCore::PopupMenuQt::updateFromElement):
* platform/qt/PopupMenuQt.h: Added.
* platform/qt/QtAbstractWebPopup.h:
* platform/qt/SearchPopupMenuQt.cpp:
(WebCore::SearchPopupMenuQt::SearchPopupMenuQt):
(WebCore::SearchPopupMenuQt::popupMenu):
(WebCore::SearchPopupMenuQt::saveRecentSearches):
(WebCore::SearchPopupMenuQt::loadRecentSearches):
(WebCore::SearchPopupMenuQt::enabled):
* platform/qt/SearchPopupMenuQt.h: Added.
win:
* WebCore.vcproj/WebCore.vcproj:
* platform/win/PopupMenuWin.cpp:
(WebCore::PopupMenuWin::PopupMenuWin):
(WebCore::PopupMenuWin::~PopupMenuWin):
(WebCore::PopupMenuWin::disconnectClient):
(WebCore::PopupMenuWin::popupClassName):
(WebCore::PopupMenuWin::show):
(WebCore::PopupMenuWin::hide):
(WebCore::PopupMenuWin::calculatePositionAndSize):
(WebCore::PopupMenuWin::setFocusedIndex):
(WebCore::PopupMenuWin::visibleItems):
(WebCore::PopupMenuWin::listIndexAtPoint):
(WebCore::PopupMenuWin::focusedIndex):
(WebCore::PopupMenuWin::focusFirst):
(WebCore::PopupMenuWin::focusLast):
(WebCore::PopupMenuWin::down):
(WebCore::PopupMenuWin::up):
(WebCore::PopupMenuWin::invalidateItem):
(WebCore::PopupMenuWin::clientRect):
(WebCore::PopupMenuWin::incrementWheelDelta):
(WebCore::PopupMenuWin::reduceWheelDelta):
(WebCore::PopupMenuWin::scrollToRevealSelection):
(WebCore::PopupMenuWin::updateFromElement):
(WebCore::PopupMenuWin::paint):
(WebCore::PopupMenuWin::valueChanged):
(WebCore::PopupMenuWin::invalidateScrollbarRect):
(WebCore::PopupMenuWin::registerClass):
(WebCore::PopupMenuWin::PopupMenuWndProc):
(WebCore::PopupMenuWin::wndProc):
* platform/win/PopupMenuWin.h: Added.
(WebCore::PopupMenuWin::client):
(WebCore::PopupMenuWin::scrollbar):
(WebCore::PopupMenuWin::itemHeight):
(WebCore::PopupMenuWin::windowRect):
(WebCore::PopupMenuWin::popupHandle):
(WebCore::PopupMenuWin::setWasClicked):
(WebCore::PopupMenuWin::wasClicked):
(WebCore::PopupMenuWin::setScrollOffset):
(WebCore::PopupMenuWin::scrollOffset):
(WebCore::PopupMenuWin::wheelDelta):
(WebCore::PopupMenuWin::scrollbarCapturingMouse):
(WebCore::PopupMenuWin::setScrollbarCapturingMouse):
* platform/win/SearchPopupMenuWin.cpp:
(WebCore::SearchPopupMenuWin::SearchPopupMenuWin):
(WebCore::SearchPopupMenuWin::popupMenu):
(WebCore::SearchPopupMenuWin::enabled):
(WebCore::SearchPopupMenuWin::saveRecentSearches):
(WebCore::SearchPopupMenuWin::loadRecentSearches):
* platform/win/SearchPopupMenuWin.h: Added.
wx:
* platform/wx/PopupMenuWx.cpp:
(WebCore::PopupMenuWx::PopupMenuWx):
(WebCore::PopupMenuWx::~PopupMenuWx):
(WebCore::PopupMenuWx::disconnectClient):
(WebCore::PopupMenuWx::show):
(WebCore::PopupMenuWx::OnMenuItemSelected):
(WebCore::PopupMenuWx::hide):
(WebCore::PopupMenuWx::updateFromElement):
* platform/wx/PopupMenuWx.h: Added.
(WebCore::PopupMenuWx::client):
* platform/wx/SearchPopupMenuWx.cpp:
(WebCore::SearchPopupMenuWx::SearchPopupMenuWx):
(WebCore::SearchPopupMenuWx::saveRecentSearches):
(WebCore::SearchPopupMenuWx::loadRecentSearches):
(WebCore::SearchPopupMenuWx::enabled):
(WebCore::SearchPopupMenuWx::popupMenu):
* platform/wx/SearchPopupMenuWx.h: Added.
2010-07-27 Luiz Agostini <luiz.agostini@openbossa.org>
Reviewed by Darin Fisher.
PopupMenu refactoring in preparation to WebKit2
https://bugs.webkit.org/show_bug.cgi?id=42592
As ChromeClient was made responsible for providing PopupMenu and SearchPopupMenu
instances, concrete classes that inherit from ChromeClient needed to be changed to
implement the new methods.
* src/ChromeClientImpl.cpp:
(WebKit::ChromeClientImpl::selectItemWritingDirectionIsNatural):
(WebKit::ChromeClientImpl::createPopupMenu):
(WebKit::ChromeClientImpl::createSearchPopupMenu):
* src/ChromeClientImpl.h:
2010-07-27 Luiz Agostini <luiz.agostini@openbossa.org>
Reviewed by Darin Fisher.
PopupMenu refactoring in preparation to WebKit2
https://bugs.webkit.org/show_bug.cgi?id=42592
As ChromeClient was made responsible for providing PopupMenu and SearchPopupMenu
instances, concrete classes that inherit from ChromeClient needed to be changed to
implement the new methods.
* WebCoreSupport/ChromeClientEfl.cpp:
(WebCore::ChromeClientEfl::selectItemWritingDirectionIsNatural):
(WebCore::ChromeClientEfl::createPopupMenu):
(WebCore::ChromeClientEfl::createSearchPopupMenu):
* WebCoreSupport/ChromeClientEfl.h:
2010-07-27 Luiz Agostini <luiz.agostini@openbossa.org>
Reviewed by Darin Fisher.
PopupMenu refactoring in preparation to WebKit2
https://bugs.webkit.org/show_bug.cgi?id=42592
As ChromeClient was made responsible for providing PopupMenu and SearchPopupMenu
instances, concrete classes that inherit from ChromeClient needed to be changed to
implement the new methods.
* WebCoreSupport/ChromeClientGtk.cpp:
(WebKit::ChromeClient::selectItemWritingDirectionIsNatural):
(WebKit::ChromeClient::createPopupMenu):
(WebKit::ChromeClient::createSearchPopupMenu):
* WebCoreSupport/ChromeClientGtk.h:
2010-07-27 Luiz Agostini <luiz.agostini@openbossa.org>
Reviewed by Darin Fisher.
PopupMenu refactoring in preparation to WebKit2
https://bugs.webkit.org/show_bug.cgi?id=42592
As ChromeClient was made responsible for providing PopupMenu and SearchPopupMenu
instances, concrete classes that inherit from ChromeClient needed to be changed to
implement the new methods.
* WebCoreSupport/ChromeClientHaiku.cpp:
(WebCore::ChromeClientHaiku::selectItemWritingDirectionIsNatural):
(WebCore::ChromeClientHaiku::createPopupMenu):
(WebCore::ChromeClientHaiku::createSearchPopupMenu):
* WebCoreSupport/ChromeClientHaiku.h:
2010-07-27 Luiz Agostini <luiz.agostini@openbossa.org>
Reviewed by Darin Fisher.
PopupMenu refactoring in preparation to WebKit2
https://bugs.webkit.org/show_bug.cgi?id=42592
As ChromeClient was made responsible for providing PopupMenu and SearchPopupMenu
instances, concrete classes that inherit from ChromeClient needed to be changed to
implement the new methods.
* WebCoreSupport/WebChromeClient.h:
* WebCoreSupport/WebChromeClient.mm:
(WebChromeClient::selectItemWritingDirectionIsNatural):
(WebChromeClient::createPopupMenu):
(WebChromeClient::createSearchPopupMenu):
2010-07-27 Luiz Agostini <luiz.agostini@openbossa.org>
Reviewed by Darin Fisher.
PopupMenu refactoring in preparation to WebKit2
https://bugs.webkit.org/show_bug.cgi?id=42592
As ChromeClient was made responsible for providing PopupMenu and SearchPopupMenu
instances, concrete classes that inherit from ChromeClient needed to be changed to
implement the new methods.
* WebCoreSupport/ChromeClientQt.cpp:
(WebCore::ChromeClientQt::selectItemWritingDirectionIsNatural):
(WebCore::ChromeClientQt::createPopupMenu):
(WebCore::ChromeClientQt::createSearchPopupMenu):
* WebCoreSupport/ChromeClientQt.h:
2010-07-27 Luiz Agostini <luiz.agostini@openbossa.org>
Reviewed by Darin Fisher.
PopupMenu refactoring in preparation to WebKit2
https://bugs.webkit.org/show_bug.cgi?id=42592
As ChromeClient was made responsible for providing PopupMenu and SearchPopupMenu
instances, concrete classes that inherit from ChromeClient needed to be changed to
implement the new methods.
* WebCoreSupport/WebChromeClient.cpp:
(WebChromeClient::selectItemWritingDirectionIsNatural):
(WebChromeClient::createPopupMenu):
(WebChromeClient::createSearchPopupMenu):
* WebCoreSupport/WebChromeClient.h:
2010-07-27 Luiz Agostini <luiz.agostini@openbossa.org>
Reviewed by Darin Fisher.
PopupMenu refactoring in preparation to WebKit2
https://bugs.webkit.org/show_bug.cgi?id=42592
As ChromeClient was made responsible for providing PopupMenu and SearchPopupMenu
instances, concrete classes that inherit from ChromeClient needed to be changed to
implement the new methods.
* WebKitSupport/ChromeClientWx.cpp:
(WebCore::ChromeClientWx::selectItemWritingDirectionIsNatural):
(WebCore::ChromeClientWx::createPopupMenu):
(WebCore::ChromeClientWx::createSearchPopupMenu):
* WebKitSupport/ChromeClientWx.h:
2010-07-27 Luiz Agostini <luiz.agostini@openbossa.org>
Reviewed by Darin Fisher.
PopupMenu refactoring in preparation to WebKit2
https://bugs.webkit.org/show_bug.cgi?id=42592
Classes WebPopupMenu and WebSearchPopupMenu inherit from PopupMenu and
SearchPopupMenu respectively. At this point they are just empty implementations.
* WebProcess/WebCoreSupport/WebPopupMenu.cpp: Added.
(WebKit::WebPopupMenu::WebPopupMenu):
(WebKit::WebPopupMenu::~WebPopupMenu):
(WebKit::WebPopupMenu::disconnectClient):
(WebKit::WebPopupMenu::show):
(WebKit::WebPopupMenu::hide):
(WebKit::WebPopupMenu::updateFromElement):
* WebProcess/WebCoreSupport/WebPopupMenu.h: Added.
* WebProcess/WebCoreSupport/WebSearchPopupMenu.cpp: Added.
(WebKit::WebSearchPopupMenu::WebSearchPopupMenu):
(WebKit::WebSearchPopupMenu::popupMenu):
(WebKit::WebSearchPopupMenu::saveRecentSearches):
(WebKit::WebSearchPopupMenu::loadRecentSearches):
(WebKit::WebSearchPopupMenu::enabled):
* WebProcess/WebCoreSupport/WebSearchPopupMenu.h: Added.
As ChromeClient was made responsible for providing PopupMenu and SearchPopupMenu
instances, concrete classes that inherit from ChromeClient needed to be changed to
implement the new methods.
* WebProcess/WebCoreSupport/WebChromeClient.cpp:
(WebKit::WebChromeClient::selectItemWritingDirectionIsNatural):
(WebKit::WebChromeClient::createPopupMenu):
(WebKit::WebChromeClient::createSearchPopupMenu):
* WebProcess/WebCoreSupport/WebChromeClient.h:
build issues:
* WebKit2.xcodeproj/project.pbxproj:
* win/WebKit2.vcproj: |
| 64424 31.07.2010 23:55:18, by
atwilson@chromium.org
Unreviewed un-rollback of r64375 so Satish can land his fixes.
* fast/speech/input-appearance-numberandspeech-expected.txt: Added.
* fast/speech/input-appearance-numberandspeech.html: Added.
* fast/speech/input-appearance-searchandspeech-expected.txt: Added.
* fast/speech/input-appearance-searchandspeech.html: Added.
* fast/speech/input-appearance-speechbutton-expected.txt: Added.
* fast/speech/input-appearance-speechbutton.html: Added.
* platform/chromium/drt_expectations.txt:
* platform/chromium/test_expectations.txt:
* platform/gtk/Skipped:
* platform/mac/Skipped:
* platform/qt/Skipped:
* platform/win/Skipped: |
| 64423 31.07.2010 23:04:16, by
commit-queue@webkit.org
2010-07-31 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r64422.
http://trac.webkit.org/changeset/64422
https://bugs.webkit.org/show_bug.cgi?id=43304
Build fixes are needed for Snow Leopard and Windows.
(Requested by lca on #webkit).
* GNUmakefile.am:
* WebCore.exp.in:
* WebCore.gypi:
* WebCore.pro:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* loader/EmptyClients.h:
* page/Chrome.cpp:
* page/Chrome.h:
* page/ChromeClient.h:
* platform/PopupMenu.h:
(WebCore::PopupMenu::create):
(WebCore::PopupMenu::disconnectClient):
(WebCore::PopupMenu::client):
(WebCore::PopupMenu::scrollbar):
(WebCore::PopupMenu::itemHeight):
(WebCore::PopupMenu::windowRect):
(WebCore::PopupMenu::popupHandle):
(WebCore::PopupMenu::setWasClicked):
(WebCore::PopupMenu::wasClicked):
(WebCore::PopupMenu::setScrollOffset):
(WebCore::PopupMenu::scrollOffset):
(WebCore::PopupMenu::wheelDelta):
(WebCore::PopupMenu::scrollbarCapturingMouse):
(WebCore::PopupMenu::setScrollbarCapturingMouse):
(WebCore::PopupMenu::isActive):
(WebCore::PopupMenu::scrollbarCornerPresent):
* platform/SearchPopupMenu.h:
(WebCore::SearchPopupMenu::create):
* platform/brew/PopupMenuBrew.cpp:
(WebCore::PopupMenu::PopupMenu):
(WebCore::PopupMenu::~PopupMenu):
(WebCore::PopupMenu::show):
(WebCore::PopupMenu::hide):
(WebCore::PopupMenu::updateFromElement):
(WebCore::PopupMenu::itemWritingDirectionIsNatural):
* platform/brew/PopupMenuBrew.h: Removed.
* platform/brew/SearchPopupMenuBrew.cpp:
(WebCore::SearchPopupMenu::saveRecentSearches):
(WebCore::SearchPopupMenu::loadRecentSearches):
(WebCore::SearchPopupMenu::SearchPopupMenu):
(WebCore::SearchPopupMenu::enabled):
* platform/brew/SearchPopupMenuBrew.h: Removed.
* platform/chromium/PopupMenuChromium.cpp:
(WebCore::PopupMenu::PopupMenu):
(WebCore::PopupMenu::~PopupMenu):
(WebCore::PopupMenu::show):
(WebCore::PopupMenu::hide):
(WebCore::PopupMenu::updateFromElement):
(WebCore::PopupMenu::itemWritingDirectionIsNatural):
* platform/chromium/PopupMenuChromium.h:
* platform/chromium/SearchPopupMenuChromium.cpp:
(WebCore::SearchPopupMenu::SearchPopupMenu):
(WebCore::SearchPopupMenu::enabled):
(WebCore::SearchPopupMenu::saveRecentSearches):
(WebCore::SearchPopupMenu::loadRecentSearches):
* platform/chromium/SearchPopupMenuChromium.h: Removed.
* platform/efl/PopupMenuEfl.cpp:
(WebCore::PopupMenu::PopupMenu):
(WebCore::PopupMenu::~PopupMenu):
(WebCore::PopupMenu::show):
(WebCore::PopupMenu::hide):
(WebCore::PopupMenu::updateFromElement):
(WebCore::PopupMenu::itemWritingDirectionIsNatural):
* platform/efl/PopupMenuEfl.h: Removed.
* platform/efl/SearchPopupMenuEfl.cpp:
(WebCore::SearchPopupMenu::SearchPopupMenu):
(WebCore::SearchPopupMenu::saveRecentSearches):
(WebCore::SearchPopupMenu::loadRecentSearches):
(WebCore::SearchPopupMenu::enabled):
* platform/efl/SearchPopupMenuEfl.h: Removed.
* platform/gtk/PopupMenuGtk.cpp:
(WebCore::PopupMenu::PopupMenu):
(WebCore::PopupMenu::~PopupMenu):
(WebCore::PopupMenu::show):
(WebCore::PopupMenu::hide):
(WebCore::PopupMenu::updateFromElement):
(WebCore::PopupMenu::itemWritingDirectionIsNatural):
(WebCore::PopupMenu::menuItemActivated):
(WebCore::PopupMenu::menuUnmapped):
(WebCore::PopupMenu::menuPositionFunction):
(WebCore::PopupMenu::menuRemoveItem):
* platform/gtk/PopupMenuGtk.h: Removed.
* platform/gtk/SearchPopupMenuGtk.cpp:
(WebCore::SearchPopupMenu::SearchPopupMenu):
(WebCore::SearchPopupMenu::saveRecentSearches):
(WebCore::SearchPopupMenu::loadRecentSearches):
(WebCore::SearchPopupMenu::enabled):
* platform/gtk/SearchPopupMenuGtk.h: Removed.
* platform/haiku/PopupMenuHaiku.cpp:
(WebCore::PopupMenuHaiku::PopupMenuHaiku):
(WebCore::PopupMenuHaiku::~PopupMenuHaiku):
(WebCore::PopupMenu::PopupMenu):
(WebCore::PopupMenu::~PopupMenu):
(WebCore::PopupMenu::show):
(WebCore::PopupMenu::hide):
(WebCore::PopupMenu::updateFromElement):
(WebCore::PopupMenu::itemWritingDirectionIsNatural):
* platform/haiku/PopupMenuHaiku.h: Removed.
* platform/haiku/SearchPopupMenuHaiku.cpp:
(WebCore::SearchPopupMenu::SearchPopupMenu):
(WebCore::SearchPopupMenu::saveRecentSearches):
(WebCore::SearchPopupMenu::loadRecentSearches):
(WebCore::SearchPopupMenu::enabled):
* platform/haiku/SearchPopupMenuHaiku.h: Removed.
* platform/mac/PopupMenuMac.h: Removed.
* platform/mac/PopupMenuMac.mm:
(WebCore::PopupMenu::PopupMenu):
(WebCore::PopupMenu::~PopupMenu):
(WebCore::PopupMenu::clear):
(WebCore::PopupMenu::populate):
(WebCore::PopupMenu::show):
(WebCore::PopupMenu::hide):
(WebCore::PopupMenu::updateFromElement):
(WebCore::PopupMenu::itemWritingDirectionIsNatural):
* platform/mac/SearchPopupMenuMac.h: Removed.
* platform/mac/SearchPopupMenuMac.mm:
(WebCore::SearchPopupMenu::SearchPopupMenu):
(WebCore::SearchPopupMenu::enabled):
(WebCore::SearchPopupMenu::saveRecentSearches):
(WebCore::SearchPopupMenu::loadRecentSearches):
* platform/qt/PopupMenuQt.cpp:
(WebCore::PopupMenu::PopupMenu):
(WebCore::PopupMenu::~PopupMenu):
(WebCore::PopupMenu::show):
(WebCore::PopupMenu::hide):
(WebCore::PopupMenu::updateFromElement):
(WebCore::PopupMenu::itemWritingDirectionIsNatural):
* platform/qt/PopupMenuQt.h: Removed.
* platform/qt/QtAbstractWebPopup.h:
* platform/qt/SearchPopupMenuQt.cpp:
(WebCore::SearchPopupMenu::SearchPopupMenu):
(WebCore::SearchPopupMenu::saveRecentSearches):
(WebCore::SearchPopupMenu::loadRecentSearches):
(WebCore::SearchPopupMenu::enabled):
* platform/qt/SearchPopupMenuQt.h: Removed.
* platform/win/PopupMenuWin.cpp:
(WebCore::PopupMenu::PopupMenu):
(WebCore::PopupMenu::~PopupMenu):
(WebCore::PopupMenu::popupClassName):
(WebCore::PopupMenu::show):
(WebCore::PopupMenu::hide):
(WebCore::PopupMenu::calculatePositionAndSize):
(WebCore::PopupMenu::setFocusedIndex):
(WebCore::PopupMenu::visibleItems):
(WebCore::PopupMenu::listIndexAtPoint):
(WebCore::PopupMenu::focusedIndex):
(WebCore::PopupMenu::focusFirst):
(WebCore::PopupMenu::focusLast):
(WebCore::PopupMenu::down):
(WebCore::PopupMenu::up):
(WebCore::PopupMenu::invalidateItem):
(WebCore::PopupMenu::clientRect):
(WebCore::PopupMenu::incrementWheelDelta):
(WebCore::PopupMenu::reduceWheelDelta):
(WebCore::PopupMenu::scrollToRevealSelection):
(WebCore::PopupMenu::updateFromElement):
(WebCore::PopupMenu::itemWritingDirectionIsNatural):
(WebCore::PopupMenu::paint):
(WebCore::PopupMenu::valueChanged):
(WebCore::PopupMenu::invalidateScrollbarRect):
(WebCore::PopupMenu::registerClass):
(WebCore::PopupMenu::PopupMenuWndProc):
(WebCore::PopupMenu::wndProc):
* platform/win/PopupMenuWin.h: Removed.
* platform/win/SearchPopupMenuWin.cpp:
(WebCore::SearchPopupMenu::SearchPopupMenu):
(WebCore::SearchPopupMenu::enabled):
(WebCore::SearchPopupMenu::saveRecentSearches):
(WebCore::SearchPopupMenu::loadRecentSearches):
* platform/win/SearchPopupMenuWin.h: Removed.
* platform/wx/PopupMenuWx.cpp:
(WebCore::PopupMenu::PopupMenu):
(WebCore::PopupMenu::~PopupMenu):
(WebCore::PopupMenu::show):
(WebCore::PopupMenu::OnMenuItemSelected):
(WebCore::PopupMenu::hide):
(WebCore::PopupMenu::updateFromElement):
(WebCore::PopupMenu::itemWritingDirectionIsNatural):
* platform/wx/PopupMenuWx.h: Removed.
* platform/wx/SearchPopupMenuWx.cpp:
(WebCore::SearchPopupMenu::SearchPopupMenu):
(WebCore::SearchPopupMenu::saveRecentSearches):
(WebCore::SearchPopupMenu::loadRecentSearches):
(WebCore::SearchPopupMenu::enabled):
* platform/wx/SearchPopupMenuWx.h: Removed.
* rendering/RenderMenuList.cpp:
(WebCore::RenderMenuList::adjustInnerStyle):
(WebCore::RenderMenuList::showPopup):
* rendering/RenderMenuList.h:
* rendering/RenderTextControlSingleLine.cpp:
(WebCore::RenderTextControlSingleLine::~RenderTextControlSingleLine):
(WebCore::RenderTextControlSingleLine::addSearchResult):
(WebCore::RenderTextControlSingleLine::showPopup):
(WebCore::RenderTextControlSingleLine::hidePopup):
(WebCore::RenderTextControlSingleLine::updateFromElement):
(WebCore::RenderTextControlSingleLine::valueChanged):
* rendering/RenderTextControlSingleLine.h:
2010-07-31 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r64422.
http://trac.webkit.org/changeset/64422
https://bugs.webkit.org/show_bug.cgi?id=43304
Build fixes are needed for Snow Leopard and Windows.
(Requested by lca on #webkit).
* src/ChromeClientImpl.cpp:
* src/ChromeClientImpl.h:
2010-07-31 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r64422.
http://trac.webkit.org/changeset/64422
https://bugs.webkit.org/show_bug.cgi?id=43304
Build fixes are needed for Snow Leopard and Windows.
(Requested by lca on #webkit).
* WebCoreSupport/ChromeClientEfl.cpp:
* WebCoreSupport/ChromeClientEfl.h:
2010-07-31 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r64422.
http://trac.webkit.org/changeset/64422
https://bugs.webkit.org/show_bug.cgi?id=43304
Build fixes are needed for Snow Leopard and Windows.
(Requested by lca on #webkit).
* WebCoreSupport/ChromeClientGtk.cpp:
* WebCoreSupport/ChromeClientGtk.h:
2010-07-31 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r64422.
http://trac.webkit.org/changeset/64422
https://bugs.webkit.org/show_bug.cgi?id=43304
Build fixes are needed for Snow Leopard and Windows.
(Requested by lca on #webkit).
* WebCoreSupport/ChromeClientHaiku.cpp:
* WebCoreSupport/ChromeClientHaiku.h:
2010-07-31 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r64422.
http://trac.webkit.org/changeset/64422
https://bugs.webkit.org/show_bug.cgi?id=43304
Build fixes are needed for Snow Leopard and Windows.
(Requested by lca on #webkit).
* WebCoreSupport/WebChromeClient.h:
* WebCoreSupport/WebChromeClient.mm:
2010-07-31 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r64422.
http://trac.webkit.org/changeset/64422
https://bugs.webkit.org/show_bug.cgi?id=43304
Build fixes are needed for Snow Leopard and Windows.
(Requested by lca on #webkit).
* WebCoreSupport/ChromeClientQt.cpp:
* WebCoreSupport/ChromeClientQt.h:
2010-07-31 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r64422.
http://trac.webkit.org/changeset/64422
https://bugs.webkit.org/show_bug.cgi?id=43304
Build fixes are needed for Snow Leopard and Windows.
(Requested by lca on #webkit).
* WebCoreSupport/WebChromeClient.cpp:
* WebCoreSupport/WebChromeClient.h:
2010-07-31 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r64422.
http://trac.webkit.org/changeset/64422
https://bugs.webkit.org/show_bug.cgi?id=43304
Build fixes are needed for Snow Leopard and Windows.
(Requested by lca on #webkit).
* WebKitSupport/ChromeClientWx.cpp:
* WebKitSupport/ChromeClientWx.h:
2010-07-31 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r64422.
http://trac.webkit.org/changeset/64422
https://bugs.webkit.org/show_bug.cgi?id=43304
Build fixes are needed for Snow Leopard and Windows.
(Requested by lca on #webkit).
* WebKit2.xcodeproj/project.pbxproj:
* WebProcess/WebCoreSupport/WebChromeClient.cpp:
* WebProcess/WebCoreSupport/WebChromeClient.h:
* WebProcess/WebCoreSupport/WebPopupMenu.cpp: Removed.
* WebProcess/WebCoreSupport/WebPopupMenu.h: Removed.
* WebProcess/WebCoreSupport/WebSearchPopupMenu.cpp: Removed.
* WebProcess/WebCoreSupport/WebSearchPopupMenu.h: Removed.
* win/WebKit2.vcproj: |
| 64422 31.07.2010 22:17:37, by
luiz@webkit.org
2010-07-27 Luiz Agostini <luiz.agostini@openbossa.org>
Reviewed by Darin Fisher.
PopupMenu refactoring in preparation to WebKit2
https://bugs.webkit.org/show_bug.cgi?id=42592
Classes PopupMenu and SearchPopupMenu have been made pure virtual.
* platform/PopupMenu.h:
(WebCore::PopupMenu::~PopupMenu):
* platform/SearchPopupMenu.h:
(WebCore::SearchPopupMenu::~SearchPopupMenu):
Classes RenderMenuList and RenderTexyControlSingleLine have been changed to use
the new pure virtual PopupMenu and SearchPopupMenu.
* rendering/RenderMenuList.cpp:
(WebCore::RenderMenuList::adjustInnerStyle):
(WebCore::RenderMenuList::showPopup):
* rendering/RenderMenuList.h:
* rendering/RenderTextControlSingleLine.cpp:
(WebCore::RenderTextControlSingleLine::~RenderTextControlSingleLine):
(WebCore::RenderTextControlSingleLine::addSearchResult):
(WebCore::RenderTextControlSingleLine::showPopup):
(WebCore::RenderTextControlSingleLine::hidePopup):
(WebCore::RenderTextControlSingleLine::updateFromElement):
(WebCore::RenderTextControlSingleLine::valueChanged):
* rendering/RenderTextControlSingleLine.h:
Chrome and ChromeClient were made responsible for providing instances of classes
PopupMenu and SearchPopupMenu to its users.
* loader/EmptyClients.h:
(WebCore::EmptyPopupMenu::show):
(WebCore::EmptyPopupMenu::hide):
(WebCore::EmptyPopupMenu::updateFromElement):
(WebCore::EmptyPopupMenu::disconnectClient):
(WebCore::EmptySearchPopupMenu::popupMenu):
(WebCore::EmptySearchPopupMenu::saveRecentSearches):
(WebCore::EmptySearchPopupMenu::loadRecentSearches):
(WebCore::EmptySearchPopupMenu::enabled):
(WebCore::EmptyChromeClient::selectItemWritingDirectionIsNatural):
(WebCore::EmptyChromeClient::createPopupMenu):
(WebCore::EmptyChromeClient::createSearchPopupMenu):
* page/Chrome.cpp:
(WebCore::Chrome::selectItemWritingDirectionIsNatural):
(WebCore::Chrome::createPopupMenu):
(WebCore::Chrome::createSearchPopupMenu):
* page/Chrome.h:
* page/ChromeClient.h:
Original contents of files PopupMenu.h and SearchPopupMenu.h have been splited
in several files, two for each platform (PopupMenuXXX.h and SearchPopupMenuXXX.h).
Each of new the files contain the concrete classes that inherit form PopupMenu or
SearchPopupMenu and are specific for the corresponding platform.
brew:
* platform/brew/PopupMenuBrew.cpp:
(WebCore::PopupMenuBrew::PopupMenuBrew):
(WebCore::PopupMenuBrew::~PopupMenuBrew):
(WebCore::PopupMenuBrew::disconnectClient):
(WebCore::PopupMenuBrew::show):
(WebCore::PopupMenuBrew::hide):
(WebCore::PopupMenuBrew::updateFromElement):
* platform/brew/PopupMenuBrew.h: Added.
(WebCore::PopupMenuBrew::client):
* platform/brew/SearchPopupMenuBrew.cpp:
(WebCore::SearchPopupMenuBrew::saveRecentSearches):
(WebCore::SearchPopupMenuBrew::loadRecentSearches):
(WebCore::SearchPopupMenuBrew::SearchPopupMenuBrew):
(WebCore::SearchPopupMenuBrew::enabled):
(WebCore::SearchPopupMenuBrew::popupMenu):
* platform/brew/SearchPopupMenuBrew.h: Added.
chromium:
* WebCore.gypi:
* platform/chromium/PopupMenuChromium.cpp:
(WebCore::PopupMenuChromium::PopupMenuChromium):
(WebCore::PopupMenuChromium::~PopupMenuChromium):
(WebCore::PopupMenuChromium::show):
(WebCore::PopupMenuChromium::hide):
(WebCore::PopupMenuChromium::updateFromElement):
(WebCore::PopupMenuChromium::disconnectClient):
* platform/chromium/PopupMenuChromium.h:
(WebCore::PopupMenuChromium::client):
* platform/chromium/SearchPopupMenuChromium.cpp:
(WebCore::SearchPopupMenuChromium::SearchPopupMenuChromium):
(WebCore::SearchPopupMenuChromium::popupMenu):
(WebCore::SearchPopupMenuChromium::enabled):
(WebCore::SearchPopupMenuChromium::saveRecentSearches):
(WebCore::SearchPopupMenuChromium::loadRecentSearches):
* platform/chromium/SearchPopupMenuChromium.h: Added.
efl:
* platform/efl/PopupMenuEfl.cpp:
(WebCore::PopupMenuEfl::PopupMenuEfl):
(WebCore::PopupMenuEfl::~PopupMenuEfl):
(WebCore::PopupMenuEfl::show):
(WebCore::PopupMenuEfl::hide):
(WebCore::PopupMenuEfl::updateFromElement):
(WebCore::PopupMenuEfl::disconnectClient):
* platform/efl/PopupMenuEfl.h: Added.
(WebCore::PopupMenuEfl::client):
* platform/efl/SearchPopupMenuEfl.cpp:
(WebCore::SearchPopupMenuEfl::SearchPopupMenuEfl):
(WebCore::SearchPopupMenuEfl::popupMenu):
(WebCore::SearchPopupMenuEfl::saveRecentSearches):
(WebCore::SearchPopupMenuEfl::loadRecentSearches):
(WebCore::SearchPopupMenuEfl::enabled):
* platform/efl/SearchPopupMenuEfl.h: Added.
gtk:
* GNUmakefile.am:
* platform/gtk/PopupMenuGtk.cpp:
(WebCore::PopupMenuGtk::PopupMenuGtk):
(WebCore::PopupMenuGtk::~PopupMenuGtk):
(WebCore::PopupMenuGtk::show):
(WebCore::PopupMenuGtk::hide):
(WebCore::PopupMenuGtk::updateFromElement):
(WebCore::PopupMenuGtk::disconnectClient):
(WebCore::PopupMenuGtk::menuItemActivated):
(WebCore::PopupMenuGtk::menuUnmapped):
(WebCore::PopupMenuGtk::menuPositionFunction):
(WebCore::PopupMenuGtk::menuRemoveItem):
* platform/gtk/PopupMenuGtk.h: Added.
(WebCore::PopupMenuGtk::client):
* platform/gtk/SearchPopupMenuGtk.cpp:
(WebCore::SearchPopupMenuGtk::SearchPopupMenuGtk):
(WebCore::SearchPopupMenuGtk::popupMenu):
(WebCore::SearchPopupMenuGtk::saveRecentSearches):
(WebCore::SearchPopupMenuGtk::loadRecentSearches):
(WebCore::SearchPopupMenuGtk::enabled):
* platform/gtk/SearchPopupMenuGtk.h: Added.
haiku:
* platform/haiku/PopupMenuHaiku.cpp:
(WebCore::HaikuPopup::HaikuPopup):
(WebCore::HaikuPopup::~HaikuPopup):
(WebCore::PopupMenuHaiku::PopupMenuHaiku):
(WebCore::PopupMenuHaiku::~PopupMenuHaiku):
(WebCore::PopupMenuHaiku::disconnectClient):
(WebCore::PopupMenuHaiku::show):
(WebCore::PopupMenuHaiku::hide):
(WebCore::PopupMenuHaiku::updateFromElement):
* platform/haiku/PopupMenuHaiku.h: Added.
(WebCore::PopupMenuHaiku::disconnectClient):
(WebCore::PopupMenuHaiku::client):
* platform/haiku/SearchPopupMenuHaiku.cpp:
(WebCore::SearchPopupMenuHaiku::SearchPopupMenuHaiku):
(WebCore::SearchPopupMenuHaiku::saveRecentSearches):
(WebCore::SearchPopupMenuHaiku::loadRecentSearches):
(WebCore::SearchPopupMenuHaiku::enabled):
(WebCore::SearchPopupMenuHaiku::popupMenu):
* platform/haiku/SearchPopupMenuHaiku.h: Added.
mac:
* WebCore.exp.in:
* WebCore.xcodeproj/project.pbxproj:
* platform/mac/PopupMenuMac.h: Added.
(WebCore::PopupMenuMac::disconnectClient):
(WebCore::PopupMenuMac::client):
* platform/mac/PopupMenuMac.mm:
(WebCore::PopupMenuMac::PopupMenuMac):
(WebCore::PopupMenuMac::~PopupMenuMac):
(WebCore::PopupMenuMac::clear):
(WebCore::PopupMenuMac::populate):
(WebCore::PopupMenuMac::show):
(WebCore::PopupMenuMac::hide):
(WebCore::PopupMenuMac::updateFromElement):
(WebCore::PopupMenuMac::itemWritingDirectionIsNatural):
* platform/mac/SearchPopupMenuMac.h: Added.
* platform/mac/SearchPopupMenuMac.mm:
(WebCore::SearchPopupMenuMac::SearchPopupMenuMac):
(WebCore::SearchPopupMenuMac::popupMenu):
(WebCore::SearchPopupMenuMac::enabled):
(WebCore::SearchPopupMenuMac::saveRecentSearches):
(WebCore::SearchPopupMenuMac::loadRecentSearches):
qt:
* WebCore.pro:
* platform/qt/PopupMenuQt.cpp:
(WebCore::PopupMenuQt::PopupMenuQt):
(WebCore::PopupMenuQt::~PopupMenuQt):
(WebCore::PopupMenuQt::disconnectClient):
(WebCore::PopupMenuQt::show):
(WebCore::PopupMenuQt::hide):
(WebCore::PopupMenuQt::updateFromElement):
* platform/qt/PopupMenuQt.h: Added.
* platform/qt/QtAbstractWebPopup.h:
* platform/qt/SearchPopupMenuQt.cpp:
(WebCore::SearchPopupMenuQt::SearchPopupMenuQt):
(WebCore::SearchPopupMenuQt::popupMenu):
(WebCore::SearchPopupMenuQt::saveRecentSearches):
(WebCore::SearchPopupMenuQt::loadRecentSearches):
(WebCore::SearchPopupMenuQt::enabled):
* platform/qt/SearchPopupMenuQt.h: Added.
win:
* WebCore.vcproj/WebCore.vcproj:
* platform/win/PopupMenuWin.cpp:
(WebCore::PopupMenuWin::PopupMenuWin):
(WebCore::PopupMenuWin::~PopupMenuWin):
(WebCore::PopupMenuWin::disconnectClient):
(WebCore::PopupMenuWin::popupClassName):
(WebCore::PopupMenuWin::show):
(WebCore::PopupMenuWin::hide):
(WebCore::PopupMenuWin::calculatePositionAndSize):
(WebCore::PopupMenuWin::setFocusedIndex):
(WebCore::PopupMenuWin::visibleItems):
(WebCore::PopupMenuWin::listIndexAtPoint):
(WebCore::PopupMenuWin::focusedIndex):
(WebCore::PopupMenuWin::focusFirst):
(WebCore::PopupMenuWin::focusLast):
(WebCore::PopupMenuWin::down):
(WebCore::PopupMenuWin::up):
(WebCore::PopupMenuWin::invalidateItem):
(WebCore::PopupMenuWin::clientRect):
(WebCore::PopupMenuWin::incrementWheelDelta):
(WebCore::PopupMenuWin::reduceWheelDelta):
(WebCore::PopupMenuWin::scrollToRevealSelection):
(WebCore::PopupMenuWin::updateFromElement):
(WebCore::PopupMenuWin::paint):
(WebCore::PopupMenuWin::valueChanged):
(WebCore::PopupMenuWin::invalidateScrollbarRect):
(WebCore::PopupMenuWin::registerClass):
(WebCore::PopupMenuWin::PopupMenuWndProc):
(WebCore::PopupMenuWin::wndProc):
* platform/win/PopupMenuWin.h: Added.
(WebCore::PopupMenuWin::client):
(WebCore::PopupMenuWin::scrollbar):
(WebCore::PopupMenuWin::itemHeight):
(WebCore::PopupMenuWin::windowRect):
(WebCore::PopupMenuWin::popupHandle):
(WebCore::PopupMenuWin::setWasClicked):
(WebCore::PopupMenuWin::wasClicked):
(WebCore::PopupMenuWin::setScrollOffset):
(WebCore::PopupMenuWin::scrollOffset):
(WebCore::PopupMenuWin::wheelDelta):
(WebCore::PopupMenuWin::scrollbarCapturingMouse):
(WebCore::PopupMenuWin::setScrollbarCapturingMouse):
* platform/win/SearchPopupMenuWin.cpp:
(WebCore::SearchPopupMenuWin::SearchPopupMenuWin):
(WebCore::SearchPopupMenuWin::popupMenu):
(WebCore::SearchPopupMenuWin::enabled):
(WebCore::SearchPopupMenuWin::saveRecentSearches):
(WebCore::SearchPopupMenuWin::loadRecentSearches):
* platform/win/SearchPopupMenuWin.h: Added.
wx:
* platform/wx/PopupMenuWx.cpp:
(WebCore::PopupMenuWx::PopupMenuWx):
(WebCore::PopupMenuWx::~PopupMenuWx):
(WebCore::PopupMenuWx::disconnectClient):
(WebCore::PopupMenuWx::show):
(WebCore::PopupMenuWx::OnMenuItemSelected):
(WebCore::PopupMenuWx::hide):
(WebCore::PopupMenuWx::updateFromElement):
* platform/wx/PopupMenuWx.h: Added.
(WebCore::PopupMenuWx::client):
* platform/wx/SearchPopupMenuWx.cpp:
(WebCore::SearchPopupMenuWx::SearchPopupMenuWx):
(WebCore::SearchPopupMenuWx::saveRecentSearches):
(WebCore::SearchPopupMenuWx::loadRecentSearches):
(WebCore::SearchPopupMenuWx::enabled):
(WebCore::SearchPopupMenuWx::popupMenu):
* platform/wx/SearchPopupMenuWx.h: Added.
2010-07-27 Luiz Agostini <luiz.agostini@openbossa.org>
Reviewed by Darin Fisher.
PopupMenu refactoring in preparation to WebKit2
https://bugs.webkit.org/show_bug.cgi?id=42592
As ChromeClient was made responsible for providing PopupMenu and SearchPopupMenu
instances, concrete classes that inherit from ChromeClient needed to be changed to
implement the new methods.
* src/ChromeClientImpl.cpp:
(WebKit::ChromeClientImpl::selectItemWritingDirectionIsNatural):
(WebKit::ChromeClientImpl::createPopupMenu):
(WebKit::ChromeClientImpl::createSearchPopupMenu):
* src/ChromeClientImpl.h:
2010-07-27 Luiz Agostini <luiz.agostini@openbossa.org>
Reviewed by Darin Fisher.
PopupMenu refactoring in preparation to WebKit2
https://bugs.webkit.org/show_bug.cgi?id=42592
As ChromeClient was made responsible for providing PopupMenu and SearchPopupMenu
instances, concrete classes that inherit from ChromeClient needed to be changed to
implement the new methods.
* WebCoreSupport/ChromeClientEfl.cpp:
(WebCore::ChromeClientEfl::selectItemWritingDirectionIsNatural):
(WebCore::ChromeClientEfl::createPopupMenu):
(WebCore::ChromeClientEfl::createSearchPopupMenu):
* WebCoreSupport/ChromeClientEfl.h:
2010-07-27 Luiz Agostini <luiz.agostini@openbossa.org>
Reviewed by Darin Fisher.
PopupMenu refactoring in preparation to WebKit2
https://bugs.webkit.org/show_bug.cgi?id=42592
As ChromeClient was made responsible for providing PopupMenu and SearchPopupMenu
instances, concrete classes that inherit from ChromeClient needed to be changed to
implement the new methods.
* WebCoreSupport/ChromeClientGtk.cpp:
(WebKit::ChromeClient::selectItemWritingDirectionIsNatural):
(WebKit::ChromeClient::createPopupMenu):
(WebKit::ChromeClient::createSearchPopupMenu):
* WebCoreSupport/ChromeClientGtk.h:
2010-07-27 Luiz Agostini <luiz.agostini@openbossa.org>
Reviewed by Darin Fisher.
PopupMenu refactoring in preparation to WebKit2
https://bugs.webkit.org/show_bug.cgi?id=42592
As ChromeClient was made responsible for providing PopupMenu and SearchPopupMenu
instances, concrete classes that inherit from ChromeClient needed to be changed to
implement the new methods.
* WebCoreSupport/ChromeClientHaiku.cpp:
(WebCore::ChromeClientHaiku::selectItemWritingDirectionIsNatural):
(WebCore::ChromeClientHaiku::createPopupMenu):
(WebCore::ChromeClientHaiku::createSearchPopupMenu):
* WebCoreSupport/ChromeClientHaiku.h:
2010-07-27 Luiz Agostini <luiz.agostini@openbossa.org>
Reviewed by Darin Fisher.
PopupMenu refactoring in preparation to WebKit2
https://bugs.webkit.org/show_bug.cgi?id=42592
As ChromeClient was made responsible for providing PopupMenu and SearchPopupMenu
instances, concrete classes that inherit from ChromeClient needed to be changed to
implement the new methods.
* WebCoreSupport/WebChromeClient.h:
* WebCoreSupport/WebChromeClient.mm:
(WebChromeClient::selectItemWritingDirectionIsNatural):
(WebChromeClient::createPopupMenu):
(WebChromeClient::createSearchPopupMenu):
2010-07-27 Luiz Agostini <luiz.agostini@openbossa.org>
Reviewed by Darin Fisher.
PopupMenu refactoring in preparation to WebKit2
https://bugs.webkit.org/show_bug.cgi?id=42592
As ChromeClient was made responsible for providing PopupMenu and SearchPopupMenu
instances, concrete classes that inherit from ChromeClient needed to be changed to
implement the new methods.
* WebCoreSupport/ChromeClientQt.cpp:
(WebCore::ChromeClientQt::selectItemWritingDirectionIsNatural):
(WebCore::ChromeClientQt::createPopupMenu):
(WebCore::ChromeClientQt::createSearchPopupMenu):
* WebCoreSupport/ChromeClientQt.h:
2010-07-27 Luiz Agostini <luiz.agostini@openbossa.org>
Reviewed by Darin Fisher.
PopupMenu refactoring in preparation to WebKit2
https://bugs.webkit.org/show_bug.cgi?id=42592
As ChromeClient was made responsible for providing PopupMenu and SearchPopupMenu
instances, concrete classes that inherit from ChromeClient needed to be changed to
implement the new methods.
* WebCoreSupport/WebChromeClient.cpp:
(WebChromeClient::selectItemWritingDirectionIsNatural):
(WebChromeClient::createPopupMenu):
(WebChromeClient::createSearchPopupMenu):
* WebCoreSupport/WebChromeClient.h:
2010-07-27 Luiz Agostini <luiz.agostini@openbossa.org>
Reviewed by Darin Fisher.
PopupMenu refactoring in preparation to WebKit2
https://bugs.webkit.org/show_bug.cgi?id=42592
As ChromeClient was made responsible for providing PopupMenu and SearchPopupMenu
instances, concrete classes that inherit from ChromeClient needed to be changed to
implement the new methods.
* WebKitSupport/ChromeClientWx.cpp:
(WebCore::ChromeClientWx::selectItemWritingDirectionIsNatural):
(WebCore::ChromeClientWx::createPopupMenu):
(WebCore::ChromeClientWx::createSearchPopupMenu):
* WebKitSupport/ChromeClientWx.h:
2010-07-27 Luiz Agostini <luiz.agostini@openbossa.org>
Reviewed by Darin Fisher.
PopupMenu refactoring in preparation to WebKit2
https://bugs.webkit.org/show_bug.cgi?id=42592
Classes WebPopupMenu and WebSearchPopupMenu inherit from PopupMenu and
SearchPopupMenu respectively. At this point they are just empty implementations.
* WebProcess/WebCoreSupport/WebPopupMenu.cpp: Added.
(WebKit::WebPopupMenu::WebPopupMenu):
(WebKit::WebPopupMenu::~WebPopupMenu):
(WebKit::WebPopupMenu::disconnectClient):
(WebKit::WebPopupMenu::show):
(WebKit::WebPopupMenu::hide):
(WebKit::WebPopupMenu::updateFromElement):
* WebProcess/WebCoreSupport/WebPopupMenu.h: Added.
* WebProcess/WebCoreSupport/WebSearchPopupMenu.cpp: Added.
(WebKit::WebSearchPopupMenu::WebSearchPopupMenu):
(WebKit::WebSearchPopupMenu::popupMenu):
(WebKit::WebSearchPopupMenu::saveRecentSearches):
(WebKit::WebSearchPopupMenu::loadRecentSearches):
(WebKit::WebSearchPopupMenu::enabled):
* WebProcess/WebCoreSupport/WebSearchPopupMenu.h: Added.
As ChromeClient was made responsible for providing PopupMenu and SearchPopupMenu
instances, concrete classes that inherit from ChromeClient needed to be changed to
implement the new methods.
* WebProcess/WebCoreSupport/WebChromeClient.cpp:
(WebKit::WebChromeClient::selectItemWritingDirectionIsNatural):
(WebKit::WebChromeClient::createPopupMenu):
(WebKit::WebChromeClient::createSearchPopupMenu):
* WebProcess/WebCoreSupport/WebChromeClient.h:
build issues:
* WebKit2.xcodeproj/project.pbxproj:
* win/WebKit2.vcproj: |
| 64421 31.07.2010 20:36:53, by
ddkilzer@apple.com
<http://webkit.org/b/43300> Simplify variables in *.xcconfig files after adding iOS support
Reviewed by Darin Adler.
WebCore:
* Configurations/WebCore.xcconfig: Extracted
PRODUCTION_FRAMEWORKS_DIR variable.
WebKit/mac:
* Configurations/WebKit.xcconfig: Extracted
PRODUCTION_FRAMEWORKS_DIR and PRODUCTION_ROOT variables. |
| 64420 31.07.2010 19:30:54, by
zimmermann@webkit.org
2010-07-31 Nikolas Zimmermann <nzimmermann@rim.com>
Reviewed by Dirk Schulze.
HTMLStyleElement/SVGStyleElement need to share more code
https://bugs.webkit.org/show_bug.cgi?id=43293
Simplify HTMLStyleElement/SVGStyleElement. They look identically now, as all code is shared in StyleElement.
Doesn't affect any tests.
* dom/StyleElement.cpp:
(WebCore::StyleElement::StyleElement): Take createdByParser & Document arguments, to share the line number extraction logic. Store it in m_lineNumber.
(WebCore::StyleElement::insertedIntoDocument): Moved addStyleSheetCandidateNode here, to share code between HTML/SVGStyleElement.
(WebCore::StyleElement::removedFromDocument): Same for removeStyleSheetCandidateNode.
(WebCore::StyleElement::childrenChanged): Introduced new helper function.
(WebCore::StyleElement::finishParsingChildren): Ditto.
(WebCore::StyleElement::process): Use stored m_lineNumber, avoids a parameter.
(WebCore::StyleElement::createSheet): No need to call the virtual setLoading() function, just store m_loading in StyleElement, and set it from here.
(WebCore::StyleElement::isLoading): Introduced new helper function.
(WebCore::StyleElement::sheetLoaded): Ditto.
* dom/StyleElement.h:
* html/HTMLStyleElement.cpp:
(WebCore::HTMLStyleElement::HTMLStyleElement): Pass Document & createdByParser arguments to StyleElement.
(WebCore::HTMLStyleElement::finishParsingChildren): Delegate work to StyleElement.
(WebCore::HTMLStyleElement::insertedIntoDocument): Ditto.
(WebCore::HTMLStyleElement::removedFromDocument): Ditto.
(WebCore::HTMLStyleElement::childrenChanged): Ditto.
* html/HTMLStyleElement.h:
(WebCore::HTMLStyleElement::isLoading): Ditto.
(WebCore::HTMLStyleElement::sheetLoaded): Ditto.
* svg/SVGStyleElement.cpp:
(WebCore::SVGStyleElement::SVGStyleElement): Pass Document & createdByParser arguments to StyleElement.
(WebCore::SVGStyleElement::finishParsingChildren): Delegate work to StyleElement.
(WebCore::SVGStyleElement::insertedIntoDocument): Ditto.
(WebCore::SVGStyleElement::removedFromDocument): Ditto.
(WebCore::SVGStyleElement::childrenChanged): Ditto.
* svg/SVGStyleElement.h:
(WebCore::SVGStyleElement::isLoading): Ditto.
(WebCore::SVGStyleElement::sheetLoaded): Ditto. |
| 64419 31.07.2010 18:07:35, by
atwilson@chromium.org
Unreviewed expectations change for Chromium.
* platform/chromium-linux/svg/custom/massive-coordinates-expected.txt: Added. |
| 64418 31.07.2010 12:55:57, by
zimmermann@webkit.org
2010-07-31 Nikolas Zimmermann <nzimmermann@rim.com>
Not reviewed. Some more housekeeping to turn Leopard but green again.
* platform/mac-leopard/Skipped: Skip fast/text/hyphens* on Leopard, as they fail since days on the bots. Filed bug 43296.
* platform/mac/fast/table/early-table-layout-expected.txt: Added, missing in bug r64225. |
| 64417 31.07.2010 12:44:29, by
zimmermann@webkit.org
2010-07-31 Nikolas Zimmermann <nzimmermann@rim.com>
Not reviewed. Add missing pixel baseline for new svg/custom/massive-coordinates.svg test.
* platform/mac/svg/custom/massive-coordinates-expected.checksum: Added.
* platform/mac/svg/custom/massive-coordinates-expected.png: Added. |
|
|